Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type boolean MYSQL. #20045

Merged
merged 7 commits into from
Oct 27, 2023
Merged

Fix type boolean MYSQL. #20045

merged 7 commits into from
Oct 27, 2023
+256 −2

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ✔️

@terabytesoftw terabytesoftw changed the title Fix type boolean mysql Fix type boolean MYSQL. Oct 25, 2023
@terabytesoftw terabytesoftw linked an issue Oct 25, 2023 that may be closed by this pull request
Boolean MySQL migration vs. auto-model-attribute-typecast inconsistency #19808
Closed
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7005d27) 47.95% compared to head (b40de6a) 47.95%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #20045   +/-   ##
=======================================
  Coverage   47.95%   47.95%           
=======================================
  Files         445      445           
  Lines       43887    43887           
=======================================
  Hits        21045    21045           
  Misses      22842    22842
Files Coverage Δ
framework/db/mysql/Schema.php 85.30% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rob006
rob006 reviewed Oct 26, 2023
View reviewed changes
framework/CHANGELOG.md Outdated Show resolved Hide resolved
@terabytesoftw @rob006
Update framework/CHANGELOG.md
b40de6a 
Co-authored-by: Robert Korulczyk <robert@korulczyk.pl>
@samdark samdark modified the milestones: 2.0.49.1, 2.0.50 Oct 26, 2023
@bizley bizley merged commit 9476b84 into yiisoft:master Oct 27, 2023
49 checks passed
@schmunk42 schmunk42 mentioned this pull request Nov 2, 2023
Closed
@what-the-diff what-the-diff bot mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bizley bizley bizley left review comments

@rob006 rob006 rob006 left review comments

@Arhell Arhell Arhell approved these changes

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.50
Development

Successfully merging this pull request may close these issues.

Boolean MySQL migration vs. auto-model-attribute-typecast inconsistency
5 participants
@terabytesoftw @samdark @rob006 @bizley @Arhell